Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dummy app generator to skip Bootsnap and Webpack in Rails 6 #3327

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Fix dummy app generator to skip Bootsnap and Webpack in Rails 6 #3327

merged 1 commit into from
Sep 9, 2019

Conversation

aldesantis
Copy link
Member

Description

Fixes the dummy app generator, which now fails because Rails 6 uses Bootsnap and Webpacker by default, which are not included in our Gemfile (and not needed for the dummy app).

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@aldesantis
Fix dummy app generator to skip Bootsnap and Webpack in Rails 6
72b7bfe 
Because Bootsnap and Webpacker are not included in our Gemfile,
the dummy app generator would fail when attempting to create a
new dummy app.
tvdeyen
tvdeyen approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kennyadsl
kennyadsl approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jacobherrington
jacobherrington approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aldesantis!

@kennyadsl kennyadsl merged commit 0c9670e into solidusio:master Sep 9, 2019
@Wooody82
Copy link

Wooody82 commented Apr 2, 2020 •
edited
Loading

Hi,
Do we need to remove the bootsnap from /sandbox/config/boot.rb
require 'bootsnap/setup' # Speed up boot time by caching expensive operations.

And remove it as welll from the gemfile ?
/sandbox/Gemfile
Reduces boot times through caching; required in config/boot.rb
gem 'bootsnap', '>= 1.4.2', require: false

I tried to install extensions and I does not work, I got error:
after I run this:
bundle exec bin/rails g solidus_comments:install

Traceback (most recent call last):
	3: from bin/rails:3:in `<main>'
	2: from bin/rails:3:in `require_relative'
	1: from /Development/App/solidus/sandbox/config/boot.rb:4:in `<top (required)>'
/Development/App/solidus/sandbox/config/boot.rb:4:in `require': cannot load such file -- bootsnap/setup (LoadError)

btw, I am running:
Rails 6.0.2.2
ruby 2.6.3p62
And Solidus later version "master"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aldesantis @Wooody82 @tvdeyen @kennyadsl @jacobherrington